feat(core): replace the OS keyboard in favor of an in-app keyboard on seed entry - #2564
feat(core): replace the OS keyboard in favor of an in-app keyboard on seed entry#2564wired-pasteque wants to merge 1 commit into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
e59680a to
6820556
Compare
|
@claude, check the fixes |
|
Claude finished @wired-pasteque's task in 3m 33s —— View job Fix verification — all previous findings addressed ✅
I re-checked every finding from the previous review against the current branch. All the substantive ones are fixed, each with test coverage. I found no new issues introduced by the fixes. 🐛 RangeError after shrinking the length — fixed
🔒 Semantics exposure — fixed
Dead code / auto-advance — resolved
Passphrase field — fixed
Nits
Still standing (deliberate trade-offs, not bugs)These are documented by-design decisions that deserve an explicit product ack, not code changes: screen-reader users cannot enter a seed at all (the exclusion is now consistent, which is the point), and hardware-keyboard/paste entry no longer works for seed words. Verification caveatFlutter isn't available in this runner, so I couldn't execute the test suite locally; verification is by reading the code and tests. The PR's |
Seed words were typed into ordinary text fields, so every keystroke passed through the platform IME - a third-party keyboard, the autocorrect/prediction cache, or a malicious accessibility service could read the recovery phrase as it was typed.
Changes:
Random.secure(), rejecting arrangements where >6 of 26 keys stay put).Screen.Recording.2026-08-06.at.6.26.05.PM.mov